Alter string concatenation based on recommendation in ticket ONSDESYS… #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ons-design-system-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
precious-onyenaucheya-ons
approved these changes
Jan 29, 2025
|
This can be tested in design-system-python-flask-demo PR https://github.com/ONSdigital/design-system-python-flask-demo/pull/15. |
rmccar
approved these changes
Jan 30, 2025
…t-work-with-babel-translation
admilne
deleted the
fix/ONSDESYS-231/copyright-declaration-doesnt-work-with-babel-translation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Applies the change suggested in ONSDESYS-231
I wasn't sure how to test this locally to see if it fixes the specific issue raised but applying the suggested fix doesn't appear to break anything.
Unfortunately I couldn't find anything in the nunjucks documentation around string concatenation but I believe Nunjucks is based on Jinja and the
~is used for string concatenation. A ChatGPT solution also suggested~is the correct way to concatenate strings.How to review this PR
Run the tests and check nothing breaks.
Checklist
This needs to be completed by the person raising the PR.